Home

mweinbach / agent-coworker

publicmweinbach/agent-coworker
Code Branches Pull requestsIssuesInsights
main
Home Code PRsIssues

test: cover preflight Codex gates, startup failures, and ask idempotence

open
Stack 2/2
#302 opened by cursor[bot]cursor/missing-test-coverage-94a9→main
Conversation6
cursor[bot]
Commits
6
Files changed6
opened this pull request
Author
· last week

Summary

Adds focused regression coverage for residual high-risk seams on main beyond open coverage PRs #298–#301. No production behavior changes.

Risky behavior now covered

  • Codex creation preflight runtime gate — missing managed Codex app-server blocks with installCodexRuntime; available app-server reports runtime_ready: ok.
  • Provider-catalog load failure still appends runtime checks — catalog outages cannot hide Codex/runtime readiness (including the Codex repair action).
  • Concurrent startup bootstrap failure aggregation — independent runtime + default-skills setup failures compose into startup diagnostics; single-leg failure still surfaces without hanging readiness.
  • Equal duplicate ask responses on the live socket — identical retries replay serverRequest/resolved instead of raising interaction_response_conflict; conflicting answers still conflict.
  • MCP workspace cache reload after throwing stale close() — config-change reload logs the stale-close failure, drops the old entry, and loads the new tool set.

Test files added/updated

  • test/creation-preflight.test.ts
  • test/server.test.ts
  • test/jsonrpc/flow.prompts.test.ts
  • test/mcp.cache.test.ts
  • apps/desktop/test/research-readiness.test.tsx (CI stabilizer: desktop bridge + persistence reset)
  • apps/mobile/bun.lock (canary Bun lockfile refresh)

Why these tests materially reduce regression risk

These paths gate session creation (Codex readiness), first-connection startup diagnostics, interactive turn recovery after double-submit/reconnect races, and MCP tool correctness after config edits. Regressions here block valid Codex sessions, leave clients with ambiguous startup state, stick turns on equal retries, or keep stale MCP tools attached after reload.

Deliberately avoided duplicating open coverage PRs #298–#301 (all green at audit time).

Validation

  • Targeted suites green
  • Touched files Biome-clean (biome check)
  • bun run lint, bun run typecheck, bun run docs:check clean
  • Full bun run test: all 672 files passed (Bun 1.4.0-canary)
Open in Web View Automation 

Cursor Agent and others added 6 commits · 19 hours ago

View commits
  • test: cover concurrent startup bootstrap failure aggregation269e3eb
  • test: cover Codex creation preflight runtime gates6601a75
  • test: cover MCP cache reload when stale close throwsbede88b
  • chore: refresh canary mobile lockfile and research bridgeced4067
  • test: cover idempotent equal ask response retriesd4f7c81
  • Merge remote-tracking branch 'origin/main' into pr-autosyncc882475
This branch has no conflicts with the base branch
Merging can be performed automatically when you’re allowed to merge and required checks pass.
0 approving reviews
None yet
Checks
No checks recorded
Fast-forward
Ready to merge without a merge commit
main ← cursor/missing-test-coverage-94a9

Only the target repository owner can merge this pull request.

Sign in to comment.

Stack

2/2
1

Merge readiness

Ahead6
Behind0
Fast-forwardReady

This pull request can be merged without creating a merge commit.

Autopilot

Debug

Reviews

Approved0
ReviewersNone yet

Configure an OpenRouter key in repository settings.

Update README.md

#125 mobile-fixes ← main

Updated 2 months ago

merged
2

test: cover preflight Codex gates, startup failures, and ask idempotence

#302 main ← cursor/missing-test-coverage-94a9

Updated 19 hours ago

open