Home

mweinbach / agent-coworker

publicmweinbach/agent-coworker
Overview Code History Branches Pull requestsIssuesInsights
main
HomeOverview Code PRsIssues

fix: align remaining A2UI review follow-ups

6 months ago

567686b
Authored
Max Weinbach4/19/2026, 12:08:36 AM
This keeps the last open PR #83 review threads aligned with the code that
actually ships. The A2UI tool contract now advertises supported interaction
round-trips, browser local-state fallback preserves desktop feature flag
overrides, and the surface manager only evicts when a new distinct surface
would overflow the cap. The dock reducer keeps unconditional toolCallId
coalescing, but its docs and tests now match that intended contract.

Constraint: Review-thread fixes must preserve the current green PR behavior while landing on a new SHA
Rejected: Enforce the coalescing time window for matching toolCallId values | current grouping behavior appears intentional across projection and chat rendering
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: If toolCallId grouping semantics change later, update the dock reducer docs/tests and chat-side A2UI coalescing together
Tested: bun run typecheck; bun test test/tools/a2ui.test.ts test/a2ui/surfaceManager.test.ts apps/desktop/test/web-workspace-state.test.ts apps/desktop/test/a2ui-dock-reducer.test.ts; bun test --max-concurrency 1
Not-tested: GitHub Actions on the new commit

Parente9da784

8 files changed
  • apps/desktop/src/app/a2uiDockReducer.ts+2−2
  • apps/desktop/src/lib/webWorkspaceState.ts+1−0
  • apps/desktop/test/a2ui-dock-reducer.test.ts+16−0
  • apps/desktop/test/web-workspace-state.test.ts+18−0
  • src/server/session/A2uiSurfaceManager.ts+4−2
  • src/tools/a2ui.ts+3−2
  • test/a2ui/surfaceManager.test.ts+46−0
  • test/tools/a2ui.test.ts
+8
−0