Home

dev / openkara

publicthedavidweng/OpenKara· sync paused
Overview Code History Branches Pull requestsIssuesInsights
main
HomeOverview Code PRsIssues

test(a11y): open the General tab before changing language

merged
#718 opened by devtest/a11y-language-general-tab→main
Conversation2 Commits0
devopened this pull requestAuthor· 2 days ago

Fixes #675 (the recurring Nightly hardening Windows UI accessibility failure).

Root cause: themes-and-motion.spec.ts opened Preferences and immediately called selectOption("zh-CN") on a <select> that is only rendered on the General page. Preferences defaults to Library (or Online Sources when a registry is linked), and hidden pages are unmounted, so Playwright waited 30s for a control that was not in the DOM. This showed up as locator.selectOption timing out at line 130, on both Chromium and WebKit, for three consecutive main nightlies.

Change: select the General tab, wait for #settings-language to be visible, then change the locale. No product UI change.

Evidence from the 2026-11-09 nightly artifact: the Accessibility snapshot and screenshot show Preferences open on the Library tab, with General listed but not selected. (run)

The simplified Chinese accessibility test now selects the General tab, waits for #settings-language to be visible, and then selects zh-CN. This avoids trying to change the language while the control is not mounted on the initially selected Preferences tab.

Files changed
…
coderabbitai[bot]commented· 2 days ago

Explain Change →

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The simplified Chinese locale accessibility test now selects the General tab and locates the language control by #settings-language instead of searching <select> elements for a zh-CN option.

Changes: Accessibility test

Layer / File(s)Summary
General tab language-control check
tests/e2e/accessibility/themes-and-motion.spec.ts
The test selects the General tab before checking the language control by its ID.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

  • thedavidweng/OpenKara#699: Moves the language control to the General tab, which the test now selects before locating the control.

Suggested labels: javascript

Merge Risk: Minimal · up to 98afd

The test now opens General before selecting a language. Confirming Chinese rendering would improve coverage, but no merge-blocking risk is established.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

  • X
  • Mastodon
  • Reddit
  • LinkedIn
kilo-code-bot[bot]commented· 2 days ago

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • tests/e2e/accessibility/themes-and-motion.spec.ts

Reviewed by free · Input: 25.6K · Output: 792 · Cached: 64K

Sign in to comment.

Merge readiness

Checking mergeability after the indexing worker computes the current branch state.

Autopilot

Debug

Reviews

Approved0
ReviewersNone yet

Configure an OpenRouter key in repository settings.