Home

dev / openkara

publicthedavidweng/OpenKara· sync paused
Code Branches Pull requestsIssuesInsights
main
Home Code PRsIssues

feat(catalog): advance embedded snapshot to generation 13 (static-CRT Windows runtimes)

merged
#391 opened by devfix/363-catalog-bump→main
Conversation1
devopened this pull requestAuthor· yesterday
Commits
0
Files changed…

What changed

Advances the embedded openkara-models catalog snapshot from generation 12 (2026-08-07-002) to generation 13 (2026-08-12-001, upstream release infra-2026-08-12-001):

  • src-tauri/catalog/release-manifest.json — new upstream release manifest with the OpenKara-side model annotations (capability_limit / evaluation_fixture / known_user_effect) re-applied unchanged.
  • src-tauri/catalog/stable-pointer.json — release_id / generation / digest / size / URL advanced to the new embedded manifest.

Generation 13 rebuilds all six reduced runtimes; the two Windows runtimes are now linked with the static MSVC CRT (/MT) (CMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded plus ONNX_USE_MSVC_STATIC_RUNTIME / protobuf_MSVC_STATIC_RUNTIME / ABSL_MSVC_STATIC_RUNTIME), so onnxruntime.dll no longer imports VCRUNTIME140* / MSVCP140* and loads on clean Windows installs without the VC++ Redistributable. Refs #363, #284; upstream thedavidweng/openkara-models#90 (build flags) and #91 (generation 13 catalog). Models and the four non-Windows runtimes are functionally unchanged: same upstream v1.27.1, unchanged build flags, fresh archives/digests from upstream publish run 31670494161.

The CPU Windows runtime keeps catalog target_triple x86_64-pc-windows-msvc (generation-12 convention) so resolve_runtime still disambiguates the two Windows runtimes by execution provider.

This PR only advances the snapshot. Removing the #361 app-local CRT mitigation is the follow-up step on #363's checklist once this generation is live on main.

Verification

  • pnpm format:write — no further diff (manifest bytes stable; stable-pointer.json digest matches embedded file: sha256 de0248138f7d1de0eaa50e5eaa6afd52c961066c95c69126e827c3fd29b5182d, 113482 bytes)
  • pnpm lint — PASS
  • pnpm test — PASS (2236 tests / 196 files, via pre-push hook with coverage + patch-coverage)
  • cargo test --lib separator::catalog — PASS (27 tests, includes embedded snapshot/pointer self-consistency)
  • node scripts/prepare-onnx-runtime.mjs fresh-staged from the new release (download + size + archive digest + per-file digests) for 3 targets:
    • --target x86_64-pc-windows-msvc --provider directml — PASS
    • --target x86_64-pc-windows-msvc --provider cpu — PASS
    • host aarch64-apple-darwin (default) — PASS
  • Upstream: PE import tables of both Windows onnxruntime.dll variants verified clean of VCRUNTIME140* / MSVCP140* (remaining api-ms-win-crt-* imports are the UCRT, which ships with Windows 10+)

Gaps

  • Windows installed-app behavior is only provable in Windows CI, and src-tauri/catalog/** is not in the Branch Windows installed-app gate's pull_request path filter — so I dispatched it manually on this branch (suite=full): github.com/thedavidweng/…/31674410572. The #361 app-local CRT DLLs remain bundled by this PR, so that workflow's CRT assertions still hold here.
  • pnpm tauri build not run locally (covered by CI).
  • The three remaining runtime archives (linux x64/arm64, macOS x64) were not re-downloaded locally; their digests were verified by the upstream publish pipeline's verify step.

Residual risk

Low. Models are byte-identical to generation 12; non-Windows runtimes rebuilt with unchanged flags from the same pinned source; existing installs pick up generation 13 via catalog auto-discovery without an app release.

Summary by CodeRabbit

  • Chores
    • Updated the stable release catalog to generation 13 (2026-08-12-001).
    • Refreshed runtime artifact downloads, checksums, sizes, and extracted-file metadata.
    • Rebuilt reduced Windows CPU and DirectML runtime packages with static runtime support.
    • Updated release metadata and publication timestamp.
coderabbitai[bot]commented· yesterday

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ad003634-083f-4ff8-8beb-00fe0880aec1

📥 Commits

Reviewing files that changed from the base of the PR and between 4c66fab28ccdea3428d57d12f39519c7c8285f85 and e33703d520b584f9f7c8141b642f43e7bda2c40c.

📒 Files selected for processing (2)
  • src-tauri/catalog/release-manifest.json
  • src-tauri/catalog/stable-pointer.json

📝 Walkthrough

Walkthrough

The release catalog advances to generation 13 and release 2026-08-12-001. Model and runtime supply-chain metadata was refreshed. Reduced Windows CPU and DirectML runtimes were rebuilt with static MSVC CRT settings.

Changes

Release catalog update

Layer / File(s)Summary
Release generation and stable pointer
src-tauri/catalog/release-manifest.json, src-tauri/catalog/stable-pointer.json
Release metadata and the stable pointer now reference generation 13 and the new release identifiers.
Model and full runtime provenance
src-tauri/catalog/release-manifest.json
Model and full ONNX Runtime artifacts now use refreshed license, notice, provenance, and SBOM metadata.
Reduced runtime artifacts
src-tauri/catalog/release-manifest.json
Reduced runtime URLs, archive metadata, extracted-file metadata, and supply-chain references were refreshed across supported platforms.
Windows static-runtime rebuilds
src-tauri/catalog/release-manifest.json
The reduced Windows CPU and DirectML runtime builds now use the static MSVC CRT and static ONNX, protobuf, and Abseil runtimes.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Mergeability Score: ⚪ Minimal · up to e3370

This PR advances the embedded catalog and updates Windows runtimes to use the static CRT; the reported checks pass and no actionable merge-blocking risk remains beyond normal review.

Possibly related issues

  • thedavidweng/OpenKara#363 — Directly concerns the Windows runtime artifacts rebuilt with static MSVC CRT settings.

Possibly related PRs

  • thedavidweng/OpenKara#347 — Updates the same release manifest and stable catalog pointer for an earlier catalog generation.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the catalog update to generation 13 and the static-CRT Windows runtime change.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/363-catalog-bump

Comment [@coderabbitai](/coderabbitai) help to get the list of available commands.

Sign in to comment.

Merge readiness

Checking mergeability after the indexing worker computes the current branch state.

Autopilot

Debug

Reviews

Approved0
ReviewersNone yet

Configure an OpenRouter key in repository settings.