Home

mweinbach / agent-coworker

publicmweinbach/agent-coworker
Overview Code History Branches Pull requestsIssuesInsights
main
HomeOverview Code PRsIssues

fix: address PR review feedback on GPT-5.4 provider options

8 months ago

da413c8
Authored
claude[bot]3/8/2026, 6:00:47 PM
- Import OPENAI_*_VALUES constants from src/shared/openaiCompatibleOptions.ts
  in slash-commands.ts instead of hardcoded Set literals — prevents future
  value-set drift going undetected by TypeScript
- Replace inline SyncConfigPatch-compatible type in LocalSlashDependencies
  with the canonical SyncConfigPatch import from syncTypes.ts
- Gate success toast in setActiveProviderOption on whether set_config was
  actually dispatched; show error toast when not connected (Codex review)
- Make SyncActions.setConfig return boolean (matching sendMessage pattern)
  and update sync.tsx implementation accordingly
- Remove as any casts in workspaceDefaults.ts by importing
  OpenAiCompatibleProviderOptionsByProvider from @cowork/shared and casting
  the structurally-identical WorkspaceProviderOptions type explicitly
- Add comment in openaiCompatibleOptions.ts explaining that "none" and "xhigh"
  are client-side sentinel values, not raw OpenAI API parameters
- Add merge-order comment in startServer.ts persistProjectConfigPatch to
  document the runtime → persisted → patch priority chain
- Fix trailing whitespace in WorkspacesPage.tsx displayProviderName map
- Mention /effort alias in reasoning-effort TUI command description

Co-authored-by: mweinbach <mweinbach@users.noreply.github.com>

Parent60d0073

8 files changed
  • apps/TUI/component/prompt/slash-commands.ts+19−22
  • apps/TUI/context/sync.tsx+2−2
  • apps/TUI/context/syncTypes.ts+1−1
  • apps/desktop/src/app/store.actions/workspaceDefaults.ts+5−4
  • apps/desktop/src/ui/settings/pages/WorkspacesPage.tsx+2−1
  • src/server/startServer.ts+6−0
  • src/shared/openaiCompatibleOptions.ts+3−0
  • test/tui.slash-commands.test.ts
+7
−7