Home

mweinbach / agent-coworker

publicmweinbach/agent-coworker
Overview Code History Branches Pull requestsIssuesInsights
main
HomeOverview Code PRsIssues

fix: properly distinguish empty results from unparseable data in SLO checks

9 months ago

be68a59
Authored
claude[bot]2/11/2026, 9:10:23 PM
The previous fix incorrectly treated all null extraction results as zero,
which broke the test expecting unparseable data (like 'NaN') to fail.

Now we distinguish between:
- Empty structures (empty arrays, null, undefined) → treat as 0
- Unparseable data with content (invalid strings, NaN) → fail the check

This fixes the observability.slo.test.ts test while still addressing the
original P1 issue of empty log query results causing false SLO failures.

Co-authored-by: mweinbach <mweinbach@users.noreply.github.com>

Parent49191b7

1 file changed
  • src/observability/slo.ts+33−3