Home

mweinbach / agent-coworker

publicmweinbach/agent-coworker
Overview Code History Branches Pull requestsIssuesInsights
main
HomeOverview Code PRsIssues

fix: restore proper switch semantics for developer toggles

6 months ago

9bca6bd
Authored
mweinbach4/17/2026, 8:16:45 PM
DeveloperPage was using the shared checkbox primitive for binary settings
rows, which exposed the wrong accessibility contract for true on/off
switches. Add a shared HeroUI switch wrapper, migrate the developer-page
boolean controls onto it, and pin the behavior with a regression test.

Constraint: Desktop shared controls must follow the repo's HeroUI v3 primitives and semantics
Rejected: Restyle Checkbox in place | checkbox semantics are still needed for checklist selection elsewhere
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: Use Switch for on/off settings rows and keep Checkbox for checklist-style selection
Tested: bun test apps/desktop/test/developer-page.test.tsx; bun run typecheck; bun test
Not-tested: Manual Electron visual smoke

Parent107ccff

4 files changed
  • apps/desktop/src/components/ui/switch.tsx+45−0
  • apps/desktop/src/ui/settings/pages/DeveloperPage.tsx+7−12
  • apps/desktop/test/developer-page.test.tsx+50−0
  • tasks/lessons.md+1−0