Home

mweinbach / agent-coworker

publicmweinbach/agent-coworker
Overview Code History Branches Pull requestsIssuesInsights
main
HomeOverview Code PRsIssues

Refactor workspace feature flag types and tests

6 months ago

7313c24
Authored
mweinbach4/18/2026, 11:00:15 PM
Update workspace feature flag typings and equality logic, and replace inline JSDOM setup in tests with a shared jsdom harness.

- workspace types: change WorkspaceRecord.defaultFeatureFlags to use WorkspaceFeatureFlags (resolved form). Adjust WorkspaceDefaultsPatch to omit defaultFeatureFlags from the generic Partial and add an explicit defaultFeatureFlags?: WorkspaceFeatureFlagOverrides (override form) plus clearDefaultToolOutputOverflowChars flag.
- workspaceDefaults actions: import WorkspaceFeatureFlagOverrides and WorkspaceFeatureFlags and update workspaceFeatureFlagsEqual to accept either overrides or resolved flags, normalizing both before comparison.
- tests: remove inline JSDOM setup and use ./jsdomHarness.setupJsdom, wrap renders in try/finally to unmount the root and restore the harness to ensure proper cleanup.

These changes make the code accept both override and resolved flag shapes where needed and stabilize DOM-based tests by centralizing setup/teardown.

Parente1c1360

3 files changed
  • apps/desktop/src/app/store.actions/workspaceDefaults.ts+4−0
  • apps/desktop/src/app/store.helpers/controlSocket.ts+4−0
  • apps/desktop/test/control-socket.test.ts+1−0