4 months ago
5aa67b5Codex review (commit 96d162c): - #BB (P1): the Windows restricted-token helper provides process containment but not FS/scope enforcement, yet it satisfied requireBackend — so read-only delegates and scoped children ran unenforced on Windows. Transform results now carry enforcesScope (true only for Seatbelt/bwrap); hard-floor contexts (read-only roles, scoped children) pass requireEnforcingBackend and fail closed when no ENFORCING backend is available (absent or non-enforcing), with no unsandboxed fallback. Unscoped workspace-write on Windows still runs under the helper (partial containment + warning), preserving the Windows fix. - #DD (P2): bwrap's nested-metadata scan no longer follows symlinks (lstat, skip symlinked dirs), so a or self-referential link can't make it traverse outside the root or loop before the command runs. - #CC (P2): docs/websocket-protocol.md now documents both ordinary approvals (dangerous:false, requires_manual_review) and sandbox-denial escalations. Verified: check, typecheck, docs:check, full suite (4665 pass; pre-existing UI fails + flaky provider-timeout only).
Parent96d162c