Home

dev / openkara

publicthedavidweng/OpenKara· sync paused
Code Branches Pull requestsIssuesInsights
main
Home Code PRsIssues

#407 Word-timed Upgrade of cached online Line-timed Lyrics

closed

Opened by dev · 13 hours ago

devopened this issueAuthor· 13 hours ago

Parent

  • #402 Acquire word-timed lyrics from AMLL, then fall back to LRCLIB

What to build

Songs that already have Line-timed Lyrics from an online source first-paint those lyrics, then receive a Word-timed Upgrade. The upgrade path calls AMLL only. A confident word-timed hit replaces the cache, resets offset, and lights karaoke fill. An ambiguous or empty AMLL result leaves the current lyrics in place and stamps a seven-day probe. Network errors do not stamp. Manual, sidecar, and embedded lyrics are not replaced by this upgrade. Unsynced embedded still uses the existing full-chain automatic upgrade.

Acceptance criteria

  • First paint of cached lrc_lib / lrc_api / lrc_api_ttml is not blocked on AMLL.
  • The session requests automatic_upgrade for those online line-timed sources when they have no word tokens, including unsynced lrc_lib. Protected sources stay skipped.
  • Upgrade persist may replace those sources only with word-timed amll. A distinct probe-miss result must not share a type with “all online providers missing.”
  • Merge gate: seed lrc_lib, drive the real AMLL-only persist path with AMLL 404 and with empty/ambiguous search; the row must stay lrc_lib and must not become absent.
  • Successful miss/ambiguous stamps word_timed_checked_at (7-day TTL, same clock as negative cache). 429/5xx/timeout do not stamp. Clock failure treats the probe as fresh. An AMLL win clears the stamp.
  • Stamp-only persist is a real change so Publish Changes copies the stamp. Upgrade miss keeps a user-tuned offset. Upgrade win resets offset.
  • Session apply-filter ignores a non-amll follow-up when the current source is online line-timed.
  • ADR 0027 records Word-timed Upgrade + confidence. ADR 0028 records no AGPL AMLL player packages. Contract fetch_lyrics_online semantics update.

Blocked by

  • Ticket 3 (cold-path AMLL client, matcher, and accept-gate)
kilo-code-bot[bot]commented· 13 hours ago
devcommented· 13 hours ago

Blocked by #406. Parent acquisition spec #402.

devcommented· 12 hours ago

Claimed by implementer agent. Starting work.

devcommented· 12 hours ago

Claimed by implementer agent. Starting work.

devcommented· 11 hours ago

Implementation passed re-review (0 open issues). Word-timed Upgrade + wipe-gate tests. Mid-flight save no longer paints a stale AMLL apply.

devcommented· 7 hours ago

Shipped in #408 (merged as c3a53830). GitHub did not auto-close this because the PR used Closes #404, #405, #406, #407 — only #404 is treated as a closing reference. Word-timed Upgrade + wipe-gate tests are in main.

Sign in to comment.

Linked pull requests

No linked pull requests yet.

This issue appears to be a duplicate of github.com/thedavidweng/…/406.

Acquire Word-timed Lyrics from AMLL on a cache miss (#406)

Similarity score: 94%

This comment was generated by Kilo Auto-Triage.