Home

dev / openkara

publicthedavidweng/OpenKara· sync paused
Code Branches Pull requestsIssuesInsights
main
Home Code PRsIssues

#405 Show Supplied Romanization on the existing overlay

closed

Opened by dev · 13 hours ago

devopened this issueAuthor· 13 hours ago

Parent

  • #403 Keep the list lyrics stage and show supplied romanization

What to build

When lyrics already include Supplied Romanization (sidecar or manual TTML), the existing romanize toggle shows that text. Complete supplied romanization does not run the local romanizer, including after a catalog-language refresh. Incomplete supplied romanization keeps the supplied lines and only fills gaps locally. The list lyrics stage, karaoke fill, audience view, and AirPlay stay. No AGPL player packages. No translation line. No Apple Music center-active layout.

Acceptance criteria

  • TTML parse extracts inline x-roman (not inside background or translation) onto roman.
  • iTunes transliteration sidecar text fills roman by line key; prefer a Latn language; inline wins over sidecar.
  • x-translation and ruby are not treated as Supplied Romanization. Background x-roman is ignored.
  • A Word timing flag on a nested div clears both the div and line timing flags so child word spans are kept.
  • Overlay seed maps over kept lines (roman first). Mapping only the companion array is wrong because that array is empty for TTML.
  • Complete Supplied Romanization skips the local romanizer, including on language refresh.
  • Incomplete Supplied Romanization plus an empty companion array still shows supplied text after toggling romanize.
  • Companion LRC split still works. Existing word fill still works. No [@applemusic-like-lyrics](/applemusic-like-lyrics) dependency.

Blocked by

  • Ticket 1 (expand roman / amll types)
devcommented· 13 hours ago

Blocked by #404. Parent presentation spec #403.

devcommented· 13 hours ago

Claimed by implementer agent. Starting work.

devcommented· 13 hours ago

Claimed by implementer agent. Starting work.

devcommented· 12 hours ago

Implementation passed re-review (0 open issues). Supplied Romanization on the existing overlay. Frozen overlay seed; romanizer failure no longer wipes supplied text.

devcommented· 7 hours ago

Shipped in #408 (merged as c3a53830). GitHub did not auto-close this because the PR used Closes #404, #405, #406, #407 — only #404 is treated as a closing reference. Supplied Romanization on the existing overlay is in main.

Sign in to comment.

Linked pull requests

No linked pull requests yet.