Home

dev / openkara

publicthedavidweng/OpenKara· sync paused
Code Branches Pull requestsIssuesInsights
main
Home Code PRsIssues

#404 Expand lyric line roman and source amll

closed

Opened by dev · 13 hours ago

devopened this issueAuthor· 13 hours ago

Parent

  • #402 Acquire word-timed lyrics from AMLL, then fall back to LRCLIB
  • #403 Keep the list lyrics stage and show supplied romanization

What to build

Expand the lyrics types so a line can carry optional Supplied Romanization and a winning source can be amll. Existing lyrics behavior does not change. After this ticket, later tickets can persist AMLL wins and show supplied romanization without touching every constructor again.

Acceptance criteria

  • The lyrics payload line type includes optional roman, always serialized, null when absent, same style as section.
  • The lyrics source enum includes amll in both the IPC contract and the cache serializer, without renaming the historical lrclib / lrc_lib split.
  • All existing lyric construction sites compile with roman defaulting to null and no new source behavior.
  • The lyrics contract tables list roman and amll in the same change as the types.
  • Existing lyrics tests and IPC contract tests pass, including the new source/field cases.

Blocked by

  • None — can start immediately.
devcommented· 13 hours ago

Frontier ticket. Unblocks #405 and #406.

devcommented· 13 hours ago

Claimed by implementer agent. Starting work.

devcommented· 13 hours ago

Claimed by implementer agent. Starting work.

devcommented· 13 hours ago

Implementation passed review (0 open issues). Types only: roman + amll. No behavior change. Frontier unblocked for #405 and #406.

Sign in to comment.

Linked pull requests

No linked pull requests yet.