Home

dev / openkara

publicthedavidweng/OpenKara· sync paused
Overview Code History Branches Pull requestsIssuesInsights
main
HomeOverview Code PRsIssues

fix(setup): make the first-run flow honest about what it is asking (#272)

2 months ago

a5bda41
Authored
Davy7/26/2026, 10:27:24 PM
Four defects found by walking the onboarding on a real 1280x800 window.

The language list was capped at a hardcoded 22rem - shorter than the
viewport on every desktop size - so it clipped a row in half and left
~350px empty below it, which reads as a broken layout rather than a
scrollable list. It now follows the window height and fades at the
bottom, showing 8 languages instead of 4 and a half.

The AI-model step is gone. "Standard vs Fine-tuned (Experimental), may
produce artifacts" is not a question a first-time karaoke user can
answer, and the correct answer was already the default. The setting
stays in Settings, where someone who cares can find it. Its only useful
content - that the model downloads on first separation - moves to the
step before it.

The step indicator showed five dots, but the remote-provider screen is a
branch of the library step, so a local-library user could never fill
more than four. It now shows the three real stages.

setup.openRemoteLibrary was doing double duty as both the library-step
button label and the provider-screen heading, so the third option read
"Choose a remote provider" next to two nouns. It gets its own key.

Also: icons in every choice list were centered against two- and
three-line blocks, so they floated between lines instead of aligning
with the title.

Parentb31f375

19 files changed
  • src/components/Settings/LibrarySetup.render.test.tsx+37−8
  • src/components/Settings/LibrarySetup.tsx+27−121
  • src/locales/de.json+1−3
  • src/locales/en.json+1−3
  • src/locales/es.json+1−3
  • src/locales/fr.json+1−3
  • src/locales/id.json+1−3
  • src/locales/it.json+1−3
  • src/locales/ja.json+1−3
  • src/locales/ko.json+1−3
  • src/locales/nl.json+1−3
  • src/locales/pl.json+1−3
  • src/locales/pt-BR.json+1−3
  • src/locales/ru.json+1−3
  • src/locales/th.json+1−3
  • src/locales/tr.json+1−3
  • src/locales/vi.json+1−3
  • src/locales/zh-CN.json+1−3
  • src/locales/zh-TW.json+1−3