Home

dev / openkara

publicthedavidweng/OpenKara· sync paused
Overview Code History Branches Pull requestsIssuesInsights
main
HomeOverview Code PRsIssues

fix(lyrics): add a Reset button to the lyrics offset control (#233) (#247)

2 months ago

772489d
Authored
Davy7/26/2026, 2:56:55 AM
The font-size control next to it has one, so an offset nudged out of place could
only be walked back 0.5s at a time. Mirror the font-size Reset: a `resetOffset`
store action that no-ops at zero and otherwise routes through `adjustOffset`, so
the reset inherits its optimistic update and backend-failure recovery instead of
duplicating them.

The offset control was also the only lyrics control still carrying hardcoded
English aria-labels; move its copy to i18n along with the new button.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Parent8bdb68b

6 files changed
  • src/components/Lyrics/LyricsOffsetControl.test.tsx+14−0
  • src/components/Lyrics/LyricsOffsetControl.tsx+12−2
  • src/locales/en.json+5−1
  • src/locales/zh-CN.json+5−1
  • src/stores/lyrics-store.test.ts+32−0
  • src/stores/lyrics-store.ts+9−0