Home

boring / v2

publicBoring-Software-Inc/v2
Overview Code History Branches Pull requestsIssuesInsights Campfire Docs
main
HomeOverview Code PRsIssues

feat(forge-opengit): comment on the change request, on transitions only

2 months ago

6a2f9df
Authored
grim8/23/2026, 5:02:26 AM
Tripwire never commented on an open-git pull request. The adapter threw on
every comment action, so the check said 'blocked' and the thread never said
why — and the thread is the one place a contributor actually looks. 39 comment
rows were recorded, refused, and swept.

The refusal had a real reason: open-git's comment endpoint is create-only, no
list and no patch, so 7's 'upsert, never append' cannot be honoured. But
silence was the worse answer.

So it appends, bounded by TRANSITION. previousVerdict is what the change
request already shows, from run history: null is the first verdict, equal means
nothing has changed since the last comment. Re-pushing the same verdict adds
nothing, so a long-running blocked change request collects ONE comment instead
of one per push. A flip posts a new one explaining the change; the old stays,
because open-git offers no way to supersede it.

The POST returns the comment id, so the action row keeps a real artifact
reference even though it can never be edited.

Verified live on pull request 32 — three runs on one commit produced exactly
two comments: block (first), block (no-op), pass (flip).

Parenta540657

2 files changed
  • packages/forge-opengit/src/actions/execute.ts+26−6
  • packages/forge-opengit/src/adapter.test.ts+45−11