Home

boring / v2

publicBoring-Software-Inc/v2
Overview Code History Branches Pull requestsIssuesInsights Campfire Docs
main
HomeOverview Code PRsIssues

fix(e2e): never close a pull request without being told to

2 months ago

69b2579
Authored
grim8/22/2026, 9:08:47 AM
The interactive funnel hardcoded keep = false, so --keep could not reach it and
every funnel run closed the pull request it opened. A Ctrl-C closed it too.

keep is now a question asked at teardown, after the result is on screen: the
funnel prints the pull request url and asks before it closes anything. --keep
skips the question. An interrupt always keeps — an interrupt is not an
instruction to destroy the evidence.

This matters beyond tidiness. open-git has no closed-pull-request surface, so a
closed one cannot be inspected at all.

Parent39a542c

4 files changed
  • scripts/e2e/harness.ts+26−11
  • scripts/e2e/lib/github.ts+7−0
  • scripts/e2e/lib/interrupt.ts+21−7
  • scripts/e2e/lib/runner.ts+22−5